Hi, On Thu, Oct 10, 2013 at 01:47:26AM +0400, Valentine wrote: > >>>I would use either > >>> > >>> depends on ARM > >>> > >>>or > >>> > >>> depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST > >>> > >>>(assuming the driver can compile on non-ARM platforms, otherwise the above > >>>line could be changed to ARCH_R8A7790 || ARCH_R8A7791 || (ARM && > >>>COMPILE_TEST)). > >> > >>OK, I'll take a look. > >>Do all the drivers have to support COMPILE_TEST? > > > >There's currently no rule, but if the driver can only be compiled for a > >restricted set of platforms, I would say that supporting COMPILE_TEST would be > >a good practice. It of course needs to be restricted to the platforms on which > >the driver will actually compile :-) > > OK thanks. > I'll probably go with the safest option: > ARCH_R8A7790 || ARCH_R8A7791 || (ARM && COMPILE_TEST) > > It does compile on x86 though, and may compile on other platforms as well. why not ? What's the reason for not building under x86 ? Drivers are supposed to be just plain C, completely portable. -- balbi
Attachment:
signature.asc
Description: Digital signature
