On Wed, Oct 09, 2013 at 10:32:12PM +0200, Laurent Pinchart wrote: > Hi Valentine, > > Thank you for the patch. > > On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: > > This adds RCAR Gen2 USB phy support. The driver configures > > USB channels 0/2 which are shared between PCI USB hosts and > > USBHS/USBSS devices. It also controls internal USBHS phy. > > > > Signed-off-by: Valentine Barshak <valentine.barshak@xxxxxxxxxxxxxxxxxx> > > --- > > drivers/usb/phy/Kconfig | 13 ++ > > drivers/usb/phy/Makefile | 1 + > > drivers/usb/phy/phy-rcar-gen2-usb.c | 255 +++++++++++++++++++++ > > include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++ > > 4 files changed, 291 insertions(+) > > create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c > > create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h > > > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > > index d5589f9..297062c 100644 > > --- a/drivers/usb/phy/Kconfig > > +++ b/drivers/usb/phy/Kconfig > > @@ -214,6 +214,19 @@ config USB_RCAR_PHY > > To compile this driver as a module, choose M here: the > > module will be called phy-rcar-usb. > > > > +config USB_RCAR_GEN2_PHY > > + tristate "Renesas R-Car Gen2 USB PHY support" > > + depends on ARCH_R8A7790 || ARCH_R8A7791 > > From a development point of view it's always nice to be able to compile the > driver for a wider range of devices, even if the device is only found in the > R8A779[01]. This allows catching compilation errors, for instance caused by > API changes that affect all drivers using the API being modified. > > I would use either > > depends on ARM > > or > > depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST > > (assuming the driver can compile on non-ARM platforms, otherwise the above > line could be changed to ARCH_R8A7790 || ARCH_R8A7791 || (ARM && > COMPILE_TEST)). every driver should compile on all arches. I will be enforcing COMPILE_TEST before applying any new drivers. -- balbi
Attachment:
signature.asc
Description: Digital signature
