Re: [PATCH 1/2] USB/host: Use existing macros instead of hard-coded values in uhci-debug.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 4 Oct 2013, Deng-Cheng Zhu wrote:

> From: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxxx>
> 
> Now that UHCI IO registers have been defined in uhci-hcd.h, use them.
> 
> Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>
> Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxxx>
> ---
>  drivers/usb/host/uhci-debug.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/usb/host/uhci-debug.c b/drivers/usb/host/uhci-debug.c
> index 4557375..8e239cd 100644
> --- a/drivers/usb/host/uhci-debug.c
> +++ b/drivers/usb/host/uhci-debug.c
> @@ -310,14 +310,14 @@ static int uhci_show_status(struct uhci_hcd *uhci, char *buf, int len)
>  	unsigned short portsc1, portsc2;
>  
>  
> -	usbcmd    = uhci_readw(uhci, 0);
> -	usbstat   = uhci_readw(uhci, 2);
> -	usbint    = uhci_readw(uhci, 4);
> -	usbfrnum  = uhci_readw(uhci, 6);
> -	flbaseadd = uhci_readl(uhci, 8);
> -	sof       = uhci_readb(uhci, 12);
> -	portsc1   = uhci_readw(uhci, 16);
> -	portsc2   = uhci_readw(uhci, 18);
> +	usbcmd    = uhci_readw(uhci, USBCMD);
> +	usbstat   = uhci_readw(uhci, USBSTS);
> +	usbint    = uhci_readw(uhci, USBINTR);
> +	usbfrnum  = uhci_readw(uhci, USBFRNUM);
> +	flbaseadd = uhci_readl(uhci, USBFLBASEADD);
> +	sof       = uhci_readb(uhci, USBSOF);
> +	portsc1   = uhci_readw(uhci, USBPORTSC1);
> +	portsc2   = uhci_readw(uhci, USBPORTSC2);
>  
>  	out += sprintf(out, "  usbcmd    =     %04x   %s%s%s%s%s%s%s%s\n",
>  		usbcmd,

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux