On Fri, 4 Oct 2013, Deng-Cheng Zhu wrote: > From: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxxx> > > The logic "len = (x)" in OK(x) is dead. Clean it up. > > Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx> > Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@xxxxxxxxxx> Getting rid of the OK macro is a good idea. But the way you did it is wrong, because of a pre-existing bug in uhci_hub_control(). The function should return len, not retval. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
