Re: [PATCH] usbcore: compare and release one bos descriptor in usb_reset_and_verify_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 29, 2013 at 11:22:46AM -0700, Sarah Sharp wrote:
> On Thu, Aug 29, 2013 at 10:53:13AM -0700, Greg KH wrote:
> > On Thu, Aug 29, 2013 at 08:37:57PM +0300, Xenia Ragiadakou wrote:
> > > In usb_reset_and_verify_device(), hub_port_init() allocates a new bos
> > > descriptor to hold the value read by the device. The new bos descriptor
> > > has to be compared with the old one in order to figure out if device 's
> > > firmware has changed in which case the device has to be reenumerated.
> > > In the original code, none of the two descriptors was deallocated leading
> > > to memory leaks.
> > > 
> > > This patch compares the old bos descriptor with the new one to detect change
> > > in firmware and releases the newly allocated bos descriptor to prevent memory
> > > leak.
> > > 
> > > Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> > 
> > Shouldn't there be a "Reported-by:" and "Tested-by:" field here as well?
> 
> I don't think Xenia and I have discussed tags outside of Signed-off-bys.
> It's probably something we should add to the patch tutorial (and
> SubmittingPatches as well).

It's in SubmittingPatches already :)

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux