On Thu, Aug 29, 2013 at 10:53:13AM -0700, Greg KH wrote: > On Thu, Aug 29, 2013 at 08:37:57PM +0300, Xenia Ragiadakou wrote: > > In usb_reset_and_verify_device(), hub_port_init() allocates a new bos > > descriptor to hold the value read by the device. The new bos descriptor > > has to be compared with the old one in order to figure out if device 's > > firmware has changed in which case the device has to be reenumerated. > > In the original code, none of the two descriptors was deallocated leading > > to memory leaks. > > > > This patch compares the old bos descriptor with the new one to detect change > > in firmware and releases the newly allocated bos descriptor to prevent memory > > leak. > > > > Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx> > > Shouldn't there be a "Reported-by:" and "Tested-by:" field here as well? I don't think Xenia and I have discussed tags outside of Signed-off-bys. It's probably something we should add to the patch tutorial (and SubmittingPatches as well). Xenia, when someone reports a problem, you should use the "Reported-by:" tag to credit them. If they test your patch, and find it fixes their problem, you should add a "Tested-by:" tag. If you know you need specific people to review your patches, you can add a "Cc:" tag. There's also a "Suggested-by:" tag that might be useful here. In this case, Alan Stern suggested that the fix for Martin's problem would be to fix the BOS descriptor leak. You probably want to credit Alan in this patch. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
