On Thu, Aug 15, 2013 at 07:11:36PM -0700, Greg Kroah-Hartman wrote: > On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: > > From: Lan Tianyu <tianyu.lan@xxxxxxxxx> > > > > The pm qos NO_POWER_OFF flag is checked twice during usb device suspend > > to see if the usb port power off condition is met. This is redundant and > > also will prevent the port from being powered off if the NO_POWER_OFF > > flag is changed to 1 from 0 after the device was already suspended. > > > > More detail in the following link. > > http://marc.info/?l=linux-usb&m=136543949130865&w=2 > > > > This patch should be backported to kernels as old as 3.7, that > > contain the commit f7ac7787ad361e31a7972e2854ed8dc2eedfac3b "usb/acpi: > > Use ACPI methods to power off ports." > > > > Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx> > > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx > > --- > > drivers/usb/core/hub.c | 14 ++------------ > > 1 file changed, 2 insertions(+), 12 deletions(-) > > So, the worse that can happen for 3.11, and all existing kernels, is > that the port really will not be turned off? That doesn't feel like a > late-rc fix to me, especially as it's been around for 8 months. Ok, fair enough. I'll queue this for usb-next instead. Do you want me to remove the stable tag as well? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
