Yes, you're right. I'm sorry - this time I didn't apply numbering scheme to those 3 patches - yet they are consequential, but not depending on each other from a strict point of view. Thank you for your review Greg! On Fri, 16 Aug 2013, Greg Kroah-Hartman wrote: ==Date: Fri, 16 Aug 2013 06:49:07 -0700 ==From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> ==To: Enrico Mioso <mrkiko.rs@xxxxxxxxx> ==Cc: Bj?rn Mork <bjorn@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, == linux-usb@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx ==Subject: Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx, == rx}_fixup functions for re-use == ==On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: ==> Some drivers implementing NCM-like protocols, may re-use those functions, as is ==> the case in the huawei_cdc_ncm driver. == ==Where is that driver at, I don't see it in the kernel tree. == ==> Export them via EXPORT_SYMBOL_GPL. == ==Normally we don't export symbols until code that actually uses the ==symbols lands in the tree at the same time. == ==thanks, == ==greg k-h == -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html