hayeswang <hayeswang@xxxxxxxxxxx> : > Francois Romieu [mailto:romieu@xxxxxxxxxxxxx] [...] > > The forward declaration is not needed. > > The r8152_submit_rx() need the declaration of read_bulk_callback(), and the > read_bulk_callback() need the declaration of r8152_submit_rx(), too. It likes > a dead lock, so I have no idea how to do it without another declaration. Ok, send me a brain for Xmas. [...] > > How is it related to the subject of the patch ? > > When link down, the driver would cancel all bulks. This avoid the re-submitting > bulk. It's quite orthogonal to aggregation and could thus had been done in its own patch for readability sake. [...] > > It should be possible to retrieve more items in the spinlocked section > > so as to have a chance to batch more work. I have not thought > > too deeply > > about it. > > I only lock when I want to remove or inser the agg list, and unlock as soon as > possible. I don't think I keep locking for a long time. Sure. It doesn't make a difference if tp->rx_done doesn't grow much. Thanks. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
