On Tue, 13 Aug 2013, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2013 at 10:07:58AM -0400, Alan Stern wrote:
> > On Mon, 12 Aug 2013, Jack Pham wrote:
> >
> > > commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> > > test of EHSET") added additional code to the EHCI hub driver but it is
> > > anticipated to only have a limited audience (e.g. embedded silicon
> > > vendors and integrators). Avoid subjecting all EHCI (and in the future
> > > maybe xHCI/OHCI, etc.) HCD users to code bloat by conditionally
> > > compiling the EHSET-specific additions with a new Kconfig option,
> > > CONFIG_USB_HCD_TEST_MODE.
> > >
> > > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Jack Pham <jackp@xxxxxxxxxxxxxx>
> >
> > Quick work, thank you.
> >
> > Greg, do you object to this new Kconfig option?
>
> No, as long as:
>
> > > + include other tests that require support from a HCD driver.
> > > +
> > > + If unsure, say N.
> >
> > There should be something along the lines of: "This option is of
> > interest only to developers who need to validate their USB hardware
> > designs. It is not needed for normal use."
>
> This needs to be added, to help the distro people out in determining if
> the option should be enabled or not (I'm guessing they will all turn it
> off, right?)
They should. Jack, can you resubmit with this change?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
