On 08/13/2013 09:40 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Signed-off-by: Rupesh Gujare <rupesh.gujare@xxxxxxxxx> --- drivers/staging/ozwpan/ozhcd.c | 4 ++-- drivers/staging/ozwpan/ozhcd.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index 73d80f2..ed3ffeb 100644 --- a/drivers/staging/ozwpan/ozhcd.c +++ b/drivers/staging/ozwpan/ozhcd.c @@ -720,9 +720,9 @@ out: * polled. We release the reference we hold on the PD. * Context: softirq */ -void oz_hcd_pd_departed(void *hport) +void oz_hcd_pd_departed(struct oz_port *hport) { - struct oz_port *port = (struct oz_port *)hport; + struct oz_port *port = hport;
Do you really need a copy? Isn't it better to rename the parameter and remove this line altogether?
WBR, Sergei
Yes, that is the idea, for next patch series, as I don't want to mix two changes in single patch.
Don't think it's worth another series. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
