On Mon, 12 Aug 2013, Jack Pham wrote:
> commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> test of EHSET") added additional code to the EHCI hub driver but it is
> anticipated to only have a limited audience (e.g. embedded silicon
> vendors and integrators). Avoid subjecting all EHCI (and in the future
> maybe xHCI/OHCI, etc.) HCD users to code bloat by conditionally
> compiling the EHSET-specific additions with a new Kconfig option,
> CONFIG_USB_HCD_TEST_MODE.
>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jack Pham <jackp@xxxxxxxxxxxxxx>
Quick work, thank you.
Greg, do you object to this new Kconfig option?
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index cf521d6..b009368 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -722,3 +722,18 @@ config USB_HCD_SSB
> for ehci and ohci.
>
> If unsure, say N.
> +
> +config USB_HCD_TEST_MODE
> + bool "HCD test mode support"
> + ---help---
> + Say 'Y' to enable additional software test modes that may be
> + supported by the host controller drivers.
> +
> + One such test mode is the Embedded High-speed Host Electrical Test
> + (EHSET) for EHCI host controller hardware, specifically the "Single
> + Step Set Feature" test. Typically this will be enabled for On-the-Go
> + or embedded hosts that need to undergo USB-IF compliance testing with
> + the aid of a special test fixture. In the future, this may expand to
s/a special test fixture/special testing hardware/
> + include other tests that require support from a HCD driver.
> +
> + If unsure, say N.
There should be something along the lines of: "This option is of
interest only to developers who need to validate their USB hardware
designs. It is not needed for normal use."
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
