Re: [PATCH] HWA: avoid constant suspend and resume on the root hub

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 08/08/2013 11:41 PM, Thomas Pugliese wrote:

Prevent the USB core from suspending the HWA root hub since bus_suspend
and bus_resume are not yet supported.  Otherwise the PM system will chew
up CPU time constantly attempting to suspend and resume the root hub but
never succeeding.

Signed-off-by: Thomas Pugliese <thomas.pugliese@xxxxxxxxx>

diff --git a/drivers/usb/host/hwa-hc.c b/drivers/usb/host/hwa-hc.c
index 483990c..02650f7 100644
--- a/drivers/usb/host/hwa-hc.c
+++ b/drivers/usb/host/hwa-hc.c
@@ -161,6 +161,11 @@ static int hwahc_op_start(struct usb_hcd *usb_hcd)
  	usb_hcd->uses_new_polling = 1;
  	set_bit(HCD_FLAG_POLL_RH, &usb_hcd->flags);
  	usb_hcd->state = HC_STATE_RUNNING;
+
+	/* prevent USB core from suspending the root hub since
+	 * bus_suspend and bus_resume are not yet supported. */

According to Documentation/CodingStyle, the preferred style of multi-line comments is this:

/*
 * bla
 * bla
 */

+	pm_runtime_get_noresume(&usb_hcd->self.root_hub->dev);
+
  	result = 0;
  out:
  	mutex_unlock(&wusbhc->mutex);

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux