Re: [PATCH] alauda: do not use stack for URB transfer_buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 August 2013 08:50:53 +0300, Jussi Kivilinna wrote:
> On 06.08.2013 19:49, Jörn Engel wrote:
> > On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote:
> >>
> >> Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to
> >> be DMA-able, which stack is not.
> >>
> >> Patch is only compile tested.
> > 
> > I have tested the driver back when I wrote it.  Not sure why it worked
> > then, maybe the chip in my notebook back then didn't care about
> > alignment or I just got lucky with the memory allocations.
> 
> You might not see problems with your hardware/architecture.
> 
> "Documentation/DMA-API-HOWTO.txt" discusses about "What memory is DMA'able?".

Makes sense.  I've read your patch over and it also makes sense.
Acked-by: Joern Engel <joern@xxxxxxxxx>

Jörn

--
It's just what we asked for, but not what we want!
-- anonymous
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux