On 07.08.2013 16:59, Torsten Schenk wrote: > On Wed, 07 Aug 2013 14:43:43 +0200 > Takashi Iwai <tiwai@xxxxxxx> wrote: > >> At Tue, 06 Aug 2013 14:53:24 +0300, >> Jussi Kivilinna wrote: >>> >>> Patch fixes 6fire not to use stack as URB transfer_buffer. URB >>> buffers need to be DMA-able, which stack is not. Furthermore, >>> transfer_buffer should not be allocated as part of larger device >>> structure because DMA coherency issues and patch fixes this issue >>> too. > > Thanks for the information. There is another section where this applies > in midi.c/midi.h. I can post a patch later. Appearently in pcm.c/pcm.h too: http://lxr.free-electrons.com/source/sound/usb/6fire/pcm.c#L571 http://lxr.free-electrons.com/source/sound/usb/6fire/pcm.h#L35 -Jussi > >>> >>> Patch is only compile tested. >> >> The changes look OK, but I'd like to let it checked with a real >> hardware before putting to stable kernel. >> >> Torsten, could you check this? > > The patch works nicely. > > I'm just wondering if instead of calling kmalloc() every time it'd be > better to put a global sender_buffer and a mutex into the comm_runtime > struct and lock it every time a writeX is performed. This also would > have the advantage that message blocks would never overlap which > currently is possible. > > I can prepare a patch on top of this one and send it later, if you > agree. > > Thanks, > Torsten > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
