On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: > On Mon, 5 Aug 2013, Sarah Sharp wrote: > > > Please review these two bug fixes for the USB port power off mechanism. > > I especially need review for the second patch, since it involves issues > > with the runtime status of the USB port. > > > > These two patches were tested on a Haswell ULT Sawtooth Peak system. > > With these two patches, USB 2.0 port power off seems to work as > > expected. > > > ---------------------------------------------------------------- > > Lan Tianyu (1): > > usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend() > > > > Sarah Sharp (1): > > usb: Don't fail port power resume on device disconnect. > > Patch 1 has been rendered out of date by intervening changes (commit > 4fae6f0fa86f in Greg's usb-next tree). Greg, could that be marked for stable? I'm not sure why it's in usb-next; it should really be in usb-linus, since it's a bug fix. The USB port power off mechanism doesn't work for suspended USB devices without it. > Patch 2 looks generally okay. I would suggest that the dev_dbg() > message be left intact. Ok, I'll revise it. Thanks, Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
