On Wed, Jul 31, 2013 at 10:46:45AM +0200, Uwe Kleine-König wrote: > OK, so the possible problem is that remove is called while the irq is > still active. That means you have to assert that all resources the irq > handler is using (e.g. ioremap, clk_prepare_enable) are only freed > *after* the irq is done. For ioremap that means it must be done using > devm_ioremap_resource. For a clock it's not that easy because the irq > handler has to assert that a used clk is kept prepared which can only be > done using clk_prepare which in turn is not allowed in an irq handler. > Hmm. So the only possible fixes are > - devm* can be told to also care about clk_disable_unprepare > - after disabling irqs in the remove callback wait for all > active irqs to be done. (i.e. call synchronize_irq(irq)) > - don't use devm_request_irq I'm not sure that devm_ guarantees any ordering in the cleanups it does so I'd not like to rely on the first option either, if there were some guarantee of that it'd help. The nice thing about explicitly freeing the IRQ is that you can tell that all this stuff is safe by inspection.
Attachment:
signature.asc
Description: Digital signature
