On Tue, Jul 30, 2013 at 10:04:29PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > By using devm_request_irq() we don't need to call free_irq(), which simplifies > the code a bit. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > --- > drivers/usb/chipidea/core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 5cc1b02..d185c41 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -502,8 +502,8 @@ static int ci_hdrc_probe(struct platform_device *pdev) > } > > platform_set_drvdata(pdev, ci); > - ret = request_irq(ci->irq, ci_irq, IRQF_SHARED, ci->platdata->name, > - ci); > + ret = devm_request_irq(dev, ci->irq, ci_irq, IRQF_SHARED, > + ci->platdata->name, ci); > if (ret) > goto stop; > > @@ -514,7 +514,6 @@ static int ci_hdrc_probe(struct platform_device *pdev) > if (!ret) > return 0; > > - free_irq(ci->irq, ci); > stop: > ci_role_stop(ci); > rm_wq: > @@ -531,7 +530,6 @@ static int ci_hdrc_remove(struct platform_device *pdev) > dbg_remove_files(ci); > flush_workqueue(ci->wq); > destroy_workqueue(ci->wq); > - free_irq(ci->irq, ci); > ci_role_stop(ci); > > return 0; > -- > 1.8.1.2 > > Reviewed-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
