On Tue, Jul 30, 2013 at 05:54:26PM +0900, Jingoo Han wrote:
> On Tuesday, July 30, 2013 5:44 PM, Felipe Balbi wrote:
> > On Tue, Jul 30, 2013 at 05:37:03PM +0900, Jingoo Han wrote:
> > > > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
> > > > > index 8747fa6..d42ec85 100644
> > > > > --- a/drivers/usb/host/ohci-omap.c
> > > > > +++ b/drivers/usb/host/ohci-omap.c
> > > > > @@ -191,7 +191,8 @@ static void start_hnp(struct ohci_hcd *ohci)
> > > > > static int ohci_omap_init(struct usb_hcd *hcd)
> > > > > {
> > > > > struct ohci_hcd *ohci = hcd_to_ohci(hcd);
> > > > > - struct omap_usb_config *config = hcd->self.controller->platform_data;
> > > > > + struct omap_usb_config *config =
> > > > > + dev_get_platdata(hcd->self.controller);
> > > >
> > > > no need to break the line here.
> > >
> > > Hi Felipe Balbi,
> > >
> > > I did it in order to remove the following checkpatch warning. :(
> > >
> > > WARNING: line over 80 characters
> > > #194: FILE: usb/host/ohci-omap.c:194:
> > > + struct omap_usb_config *config = dev_get_platdata(hcd->self.controller);
> > >
> > > Do you have any idea? :)
> >
> > that one you can ignore. Breaking the line makes it harder to read :-)
> >
> OK, I see. :)
> Thank you for your answer.
> I will send v2 patch.
same goes for omap_wdt.c on the other patch btw :-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
