Re: [PATCH] USB: ohci_usb warn "irq nobody cared" on shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 Jul 2013, Caizhiyong wrote:

> From: caizhiyong <caizhiyong@xxxxxxxxxx>
> 
> When ohci-hcd is shutting down, call ohci_usb_reset reset ohci-hcd,
> the root hub generate an interrupt, but ohci->rh_state is
> OHCI_RH_HALTED, and ohci_irq ignore the interrupt, the kernel trigger
> warning "irq nobody cared". ehci-hcd is first disable interrupts,
> then reset ehci.
> 
> this patch disable ohci interrupt before reset ohci.
> 
> The patch is tested at the arm cortex-a9 demo board.
> 
> Signed-off-by: caizhiyong <caizhiyong@xxxxxxxxxx>
> ---
>  drivers/usb/host/ohci-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index a9d3437..e4b3c63 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -938,8 +938,8 @@ static void ohci_stop (struct usb_hcd *hcd)
>  	if (quirk_nec(ohci))
>  		flush_work(&ohci->nec_work);
>  
> -	ohci_usb_reset (ohci);
>  	ohci_writel (ohci, OHCI_INTR_MIE, &ohci->regs->intrdisable);
> +	ohci_usb_reset(ohci);
>  	free_irq(hcd->irq, hcd);
>  	hcd->irq = 0;

Reviewed-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux