On Tue, Jul 02, 2013 at 08:13:52PM -0700, Jack Pham wrote:
> The USB Embedded High-speed Host Electrical Test (EHSET) defines the
> SINGLE_STEP_SET_FEATURE test as follows:
> diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
> index 2b70277..8e6dc09 100644
> --- a/drivers/usb/host/ehci-hub.c
> +++ b/drivers/usb/host/ehci-hub.c
> +static int ehset_single_step_set_feature(struct usb_hcd *hcd, int port)
> +{
> + int retval = -ENOMEM;
> + struct usb_ctrlrequest *dr;
> + struct urb *urb;
> + struct usb_device *udev;
> + struct ehci_hcd *ehci = hcd_to_ehci(hcd);
> + struct usb_device_descriptor *buf;
> + DECLARE_COMPLETION_ONSTACK(done);
> +
> + /* Obtain udev of the rhub's child port */
> + udev = hcd->self.root_hub->children[port];
Oops, I forgot to add this additional fix needed after refreshing to
latest:
- udev = hcd->self.root_hub->children[port];
+ udev = usb_hub_find_child(hcd->self.root_hub, port);
I'll wait for Felipe's response regarding whether it's appropriate to do
this in the HCD, and then will re-send without the RFC tag.
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
