Re: [PATCH v5 3/5] USB: EHCI: improve ehci_endpoint_disable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote:
> The patch does the below improvement:
> 
> - think QH_STATE_COMPLETING as unlinking state since all URBs on the
> endpoint should be in unlinking or unlinked when doing endpoint_disable()
> 
> - add "WARN_ON(!list_empty(&qh->qtd_list));" if qh->qh_state is
> QH_STATE_LINKED because there shouldn't be any active transfer in qh

If this can "never" happen, why spit a nasty message out to the error
log?  What can a user do with this?

I really don't like adding stuff like this to the kernel if at all
possible.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux