On 25.07.2013 18:39, Alan Cooper wrote:
It looks like all the feedback has been addressed, but I'm no device tree expert.
Felipe, Matthijs, and Sergei, does this look good? If so, I'll queue to my xhci tree.
Not quite there yet. Too bad I couldn't notice all the small issues at once...
Sarah Sharp On Tue, Jul 23, 2013 at 06:35:33PM -0400, Al Cooper wrote:
Add Device Tree match table to xhci-plat.c. Add DT bindings document.
Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx> --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 14 ++++++++++++++ drivers/usb/host/xhci-plat.c | 10 ++++++++++ 2 files changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.txt
diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt new file mode 100644 index 0000000..b88aee7 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt @@ -0,0 +1,14 @@
[...]
+ +Required properties: + - compatible: should be "xhci-platform". + - reg: should contain address and length of the standard XHCI + register set for the device. + - interrupts: one XHCI interrupt should be described here. + +Example: + xhci@f0931000 {
The node should be named just "usb", not "xhci" (no programming interface specific names), according to the ePAPR spec [1].
What about the existing node names "ohci@" and "ehci@"?
Unfortunately, they are all wrong, as many others. It seems almost nobody reads:
http://www.devicetree.org/Device_Tree_Usage
+ compatible = "xhci-platform";
It again looks somewhat like a driver name, not a device name. What made you change the value from "usb-xhci", Al? Look at [eo]hci-omap.txt in that directory.
I changed the name because MODULE_DEVICE_TABLE() now uses the name and that means the hotplug system will use it to identify the driver and it seems like the name should be unique enough to avoid confusion with something like the xhci-pci driver.
xhci-pci gets identified by the PCI device class, not the name. Maybe indeed "snps,xhci" is better if this is Synopsys core you're doing the binding for... I have no strong preference, it's just that "xhci-platform" doesn't appeal to me.
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
