Re: [PATCH V4] usb: Add Device Tree support to XHCI Platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It looks like all the feedback has been addressed, but I'm no device
tree expert.

Felipe, Matthijs, and Sergei, does this look good?  If so, I'll queue to
my xhci tree.

Sarah Sharp

On Tue, Jul 23, 2013 at 06:35:33PM -0400, Al Cooper wrote:
> Add Device Tree match table to xhci-plat.c. Add DT bindings document.
> 
> Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 14 ++++++++++++++
>  drivers/usb/host/xhci-plat.c                       | 10 ++++++++++
>  2 files changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/usb-xhci.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> new file mode 100644
> index 0000000..b88aee7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -0,0 +1,14 @@
> +USB XHCI controllers
> +
> +Required properties:
> +  - compatible: should be "xhci-platform".
> +  - reg: should contain address and length of the standard XHCI
> +    register set for the device.
> +  - interrupts: one XHCI interrupt should be described here.
> +
> +Example:
> +	xhci@f0931000 {
> +		compatible = "xhci-platform";
> +		reg = <0xf0931000 0x8c8>;
> +		interrupts = <0x0 0x4e 0x0>;
> +	};
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index d718134..d547f24 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -14,6 +14,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/module.h>
>  #include <linux/slab.h>
> +#include <linux/of.h>
>  
>  #include "xhci.h"
>  
> @@ -212,11 +213,20 @@ static int xhci_plat_remove(struct platform_device *dev)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id usb_xhci_of_match[] = {
> +	{ .compatible = "xhci-platform" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, usb_xhci_of_match);
> +#endif
> +
>  static struct platform_driver usb_xhci_driver = {
>  	.probe	= xhci_plat_probe,
>  	.remove	= xhci_plat_remove,
>  	.driver	= {
>  		.name = "xhci-hcd",
> +		.of_match_table = of_match_ptr(usb_xhci_of_match),
>  	},
>  };
>  MODULE_ALIAS("platform:xhci-hcd");
> -- 
> 1.8.1.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux