Re: [PATCH 01/13] staging: dwc2: fix naming of register constants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On Wed, Jul 17, 2013 at 06:44:04PM +0000, Paul Zimmerman wrote:
> > From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx]
> > Sent: Wednesday, July 17, 2013 8:10 AM
> > 
> > A generic set of FIFOSIZE_* constants was used for both the GNPTXFSIZ
> > and HPTXFSIZ registers, even where a specific set of constants was a
> > available for the GNPTXFSIZ register. This change adds specific
> > constants for the HPTXFSIZ register as well, changes the code to use
> > those specific constants and removes the generic constants.
> 
> Hi Matthijs,
> 
> I'd rather not do this, if you don't mind. The peripheral-mode register
> set also has several FIFO size registers, all of which use the exact
> same format. So I think it makes more sense to keep the generic
> versions.
Ok, I'll reverse the patch and drop the specific constants in favor of
the generic ones, then.

Gr.

Matthijs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux