Re: Incompleteness of HW capability registers (Was: [PATCH] staging: dwc2: fix thinko in dwc2_hc_set_even_odd_frame())

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Stephen,

> Ah, that makes sense. It wasn't clear to me from the config structure
> that some of the variables didn't correspond directly to config
> fields/registers in the HW.
I have a patch pending that separates configured values from hardware
values, which would help here. I'll try to send that one out today or
tomorrow, together with some other cleanups.

> It'd be nice if the DT bindings (when we create them) and/or platform
> device wrapper only explicitly set values in the config structure that
> fall into this category; anything that can be queried from HW probably
> should be.
That makes sense to me.

> Perhaps the config structure could even be split up into two
> sub-structures: One for "must specify" values which can't be probed
> from HW, and another to "override" values where the HW value is wrong
> for some reason, but usually shouldn't need to be specified.
Hmm, my patch doesn't do this (it separates detected values from set
values, not optional set values from required set values), though it
will probably make it easier to make this separation later on.

Gr.

Matthijs
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux