On 07/09/2013 05:16 PM, Alan Stern wrote: > On Tue, 9 Jul 2013, Roger Quadros wrote: > >> Most HCD drivers are doing the same thing in their ".shutdown" callback >> so it makes sense to use the generic usb_hcd_platform_shutdown() >> handler there. >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> >> --- >> drivers/usb/host/ehci-grlib.c | 11 +---------- >> drivers/usb/host/ehci-mxc.c | 10 +--------- >> drivers/usb/host/ehci-omap.c | 10 +--------- >> drivers/usb/host/ehci-ppc-of.c | 11 +---------- >> drivers/usb/host/ehci-s5p.c | 10 +--------- >> drivers/usb/host/ehci-tegra.c | 10 +--------- >> drivers/usb/host/ehci-xilinx-of.c | 17 +---------------- >> drivers/usb/host/ohci-omap3.c | 10 +--------- >> 8 files changed, 8 insertions(+), 81 deletions(-) > > This all looks fine. But unless my kernel tree is out of date, you > missed ohci-ppc-of.c. You are right. I missed it and will send a revision. I've also noticed some drivers doing non-standard stuff. e.g. - ehci-ps3.c and ohci-pst set .shutdown as well as .remove to to ps3_ehci_remove - ehci-tilegx.c and ohci-tilegx call .remove in the .shutdown path - ehci-mv.c checks for (!hcd->rh_registered) in the shudown & remove patch. Is this necessary? cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
