On Wed, Jul 03, 2013 at 07:57:16PM +0300, Felipe Balbi wrote: > On Wed, Jul 03, 2013 at 09:25:06AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Jul 03, 2013 at 04:08:42PM +0300, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Jul 02, 2013 at 12:22:05PM -0700, Greg Kroah-Hartman wrote: > > > > None of these USB files need idr.h, so don't include it. > > > > > > > > Cc: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> > > > > Cc: Felipe Balbi <balbi@xxxxxx> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > --- > > > > drivers/usb/chipidea/core.c | 1 - > > > > drivers/usb/core/endpoint.c | 1 - > > > > drivers/usb/musb/musb_core.c | 1 - > > > > 3 files changed, 3 deletions(-) > > > > > > > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > > > > index 475c9c1..34537e9 100644 > > > > --- a/drivers/usb/chipidea/core.c > > > > +++ b/drivers/usb/chipidea/core.c > > > > @@ -54,7 +54,6 @@ > > > > #include <linux/dma-mapping.h> > > > > #include <linux/platform_device.h> > > > > #include <linux/module.h> > > > > -#include <linux/idr.h> > > > > > > actually, chipidea uses DEFINE_IDA(), without this we get: > > > > > > drivers/usb/chipidea/core.c:346:8: warning: type defaults to 'int' in declaration of 'DEFINE_IDA' [-Wimplicit-int] > > > drivers/usb/chipidea/core.c:346:1: warning: parameter names (without types) in function declaration [enabled by default] > > > drivers/usb/chipidea/core.c: In function 'ci_hdrc_add_device': > > > drivers/usb/chipidea/core.c:355:2: error: implicit declaration of function 'ida_simple_get' [-Werror=implicit-function-declaration] > > > drivers/usb/chipidea/core.c:355:23: error: 'ci_ida' undeclared (first use in this function) > > > drivers/usb/chipidea/core.c:355:23: note: each undeclared identifier is reported only once for each function it appears in > > > drivers/usb/chipidea/core.c:387:2: error: implicit declaration of function 'ida_simple_remove' [-Werror=implicit-function-declaration] > > > drivers/usb/chipidea/core.c: In function 'ci_hdrc_remove_device': > > > drivers/usb/chipidea/core.c:396:21: error: 'ci_ida' undeclared (first use in this function) > > > drivers/usb/chipidea/core.c: At top level: > > > drivers/usb/chipidea/core.c:346:8: warning: 'DEFINE_IDA' declared 'static' but never defined [-Wunused-function] > > > cc1: some warnings being treated as errors > > > make[2]: *** [drivers/usb/chipidea/core.o] Error 1 > > > make[1]: *** [drivers/usb/chipidea/] Error 2 > > > make: *** [sub-make] Error 2 > > > > How is this passing the build on my box at all? Odd, thanks, I'll fix > > this up, thanks for the review on all of these. > > no problem, you can add > > Reviewed-by: Felipe Balbi <balbi@xxxxxx> > > to this one too, if you wish :-) Thanks, I will, I'll not be queueing any of these up until after 3.11-rc1 is out, so it will be a few weeks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
