Hi, On Thu, Jun 27, 2013 at 09:35:26AM +0300, Felipe Balbi wrote: > Hi, > > On Thu, Jun 27, 2013 at 08:14:16AM +0200, Michael Grzeschik wrote: > > > > right, but in DT you will define both instances and each instance will > > > > have a seaparate snps,maximum_speed attribute :-) > > > > > > > > I'm now considering if we should make maximum_speed a generic attribute, > > > > Kishon ? Alex ? Alan ? > > > > > > > > anyone else needs such thing ? > > > > > > We have a force-full-speed attibute for chipidea on the way. This > > > maximum_speed looks like a more generic alternative. Michael, what say > > > you? > > > > The maximum_speed attribute sounds more reasonable. I will change my > > patch to it. > > thanks, perhaps we can add a generic helper in udc-core or usb-common ? As this function is not only udc specific, this should go into usb-common. But right, we should go with a helper here. I will write one in addition to my full-speed patch as first user of it. Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html