On Wed, Jun 26, 2013 at 02:58:46PM +0200, Sebastian Andrzej Siewior wrote: > On 06/26/2013 02:41 PM, Felipe Balbi wrote: > > > Note that this will require defconfig changes unless someone > > knows about a choice-like Kconfig construct which allows defaults. > > You can "default y" so it will be always selected if it is possible > which was the default and drop it after a few kernel releases so > everyone doing oldconfig picked up the change. adding any default to any of those choices gives Kconfig warnings: diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index 2d12909..d452830 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -46,6 +46,7 @@ choice config USB_DWC3_OMAP tristate "Texas Instruments OMAP5 and similar Platforms" depends on EXTCON + default USB_DWC3 if EXTCON help Some platforms from Texas Instruments like OMAP5, DRA7xxx and AM437x use this IP for USB2/3 functionality. @@ -54,6 +55,7 @@ config USB_DWC3_OMAP config USB_DWC3_EXYNOS tristate "Samsung Exynos Platform" + default USB_DWC3 help Recent Exynos5 SoCs ship with one DesignWare Core USB3 IP inside, say 'Y' or 'M' if you have one such device. @@ -61,6 +63,7 @@ config USB_DWC3_EXYNOS config USB_DWC3_PCI tristate "PCIe-based Platforms" depends on PCI + default USB_DWC3 if PCI help If you're using the DesignWare Core IP with a PCIe, please say 'Y' or 'M' here. $ make [...] drivers/usb/dwc3/Kconfig:49:warning: defaults for choice values not supported drivers/usb/dwc3/Kconfig:58:warning: defaults for choice values not supported drivers/usb/dwc3/Kconfig:66:warning: defaults for choice values not supported [...] -- balbi
Attachment:
signature.asc
Description: Digital signature
