On Mon, Jun 17, 2013 at 10:40:24AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jun 17, 2013 at 09:55:17AM -0700, Sarah Sharp wrote: > > This is a revised version of the patchset that was originally sent to > > fix "security issues" identified by the Klockwork static analysis tool. > > As discussed, these weren't real security issues, mostly just Klockwork > > not understanding that BUG() would stop code execution. > > > > The older patchset did have some useful improvements, aside from the > > misguided patch to make the USB core be more robust about handling NULL > > pointers from usb_hub_to_struct_hub(). As discussed, that could only > > happen if khubd binds to a hub with no ports, and there's already a fix > > in Greg's tree to avoid that case. > > > > This new patchset focuses solely on removing instances of BUG() from the > > xHCI driver. It adds code to gracefully handle failures by returning > > standard error values, and changing the driver to handle those failure > > cases. These are against Greg's usb-next branch, and are not marked for > > stable. > > > > Please review and comment if this is the right approach. > > These all look great to me, thanks for redoing them. Do you want me to > pull them into my usb-next branch for 3.11? Sure, I'll send you a tagged pull request. Sarah -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
