This is a revised version of the patchset that was originally sent to
fix "security issues" identified by the Klockwork static analysis tool.
As discussed, these weren't real security issues, mostly just Klockwork
not understanding that BUG() would stop code execution.
The older patchset did have some useful improvements, aside from the
misguided patch to make the USB core be more robust about handling NULL
pointers from usb_hub_to_struct_hub(). As discussed, that could only
happen if khubd binds to a hub with no ports, and there's already a fix
in Greg's tree to avoid that case.
This new patchset focuses solely on removing instances of BUG() from the
xHCI driver. It adds code to gracefully handle failures by returning
standard error values, and changing the driver to handle those failure
cases. These are against Greg's usb-next branch, and are not marked for
stable.
Please review and comment if this is the right approach.
Sarah Sharp
The following changes since commit 976f8bef9cfb5246bc0e8dc781562daa79cb7aaf:
Merge tag 'usb-for-v3.11' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next (2013-06-12 14:44:13 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git fun-klockwork
for you to fetch changes up to 17d655543716791ebf8bb396b674fe95c07e55e4:
xhci: remove BUG() in xhci_get_endpoint_type() (2013-06-14 13:53:23 -0700)
----------------------------------------------------------------
Mathias Nyman (2):
xhci: Remove BUG in xhci_setup_addressable_virt_dev
xhci: remove BUG() in xhci_get_endpoint_type()
Sarah Sharp (2):
xhci: Remove BUG_ON() in xhci_alloc_container_ctx.
xhci: Remove BUG_ON in xhci_get_input_control_ctx.
drivers/usb/host/xhci-dbg.c | 5 ++
drivers/usb/host/xhci-mem.c | 61 ++++++++---------
drivers/usb/host/xhci-ring.c | 4 +
drivers/usb/host/xhci.c | 148 ++++++++++++++++++++++++++++++++----------
4 files changed, 151 insertions(+), 67 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
