On Fri, Jun 14, 2013 at 01:20:31PM +0300, Alexander Shishkin wrote: > Peter Chen <peter.chen@xxxxxxxxxxxxx> writes: > > > On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote: > >> "ci13xxx" is bad for at least the following reasons: > >> * people often mistype it > >> * it doesn't add any informational value to the names it's used in > >> * it needlessly attracts mail filters > >> > >> This patch replaces it with "ci_hdrc", "ci_udc" or "ci_hw", depending > >> on the situation. Modules with ci13xxx prefix are also renamed accordingly > >> and aliases are added for compatibility. Otherwise, no functional changes. > > > > I find the ci_udc_xxx is used for local file, why not just udc_xxx? > > Consistency. I don't remember all the function names by heart, but with > consistent naming I can at least figure them out quite easily. And you > immediately know where it's coming from when you see it in a > backtrace. And you avoid ambiguity if you have more than one function > with the same name if you end up with more than one driver defining > udc_*(). Or udc_start(). > > I'd prefer all chipidea functions have a ci_ prefix. Ack, especially when it comes to ftrace where you might need to set filters. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
