Peter Chen <peter.chen@xxxxxxxxxxxxx> writes:
> On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote:
>> "ci13xxx" is bad for at least the following reasons:
>> * people often mistype it
>> * it doesn't add any informational value to the names it's used in
>> * it needlessly attracts mail filters
>>
>> This patch replaces it with "ci_hdrc", "ci_udc" or "ci_hw", depending
>> on the situation. Modules with ci13xxx prefix are also renamed accordingly
>> and aliases are added for compatibility. Otherwise, no functional changes.
>
> I find the ci_udc_xxx is used for local file, why not just udc_xxx?
Consistency. I don't remember all the function names by heart, but with
consistent naming I can at least figure them out quite easily. And you
immediately know where it's coming from when you see it in a
backtrace. And you avoid ambiguity if you have more than one function
with the same name if you end up with more than one driver defining
udc_*(). Or udc_start().
I'd prefer all chipidea functions have a ci_ prefix.
>>
>> Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
>> ---
>> drivers/usb/chipidea/Makefile | 6 +-
>> drivers/usb/chipidea/ci.h | 50 ++---
>> .../usb/chipidea/{ci13xxx_imx.c => ci_hdrc_imx.c} | 46 ++---
>> .../usb/chipidea/{ci13xxx_imx.h => ci_hdrc_imx.h} | 0
>> .../usb/chipidea/{ci13xxx_msm.c => ci_hdrc_msm.c} | 49 ++---
>> .../usb/chipidea/{ci13xxx_pci.c => ci_hdrc_pci.c} | 43 ++--
>
> why not just ci_imx.c and ci_pci? I don't think
Suppose ChipIdea had another IP block (I'm pretty sure they do or did),
which has nothing to do with usb.
> many people understand what does "hdrc" means
If they don't understand "hdrc", they probably don't have any business
messing around drivers/usb/chipidea. :)
Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
