Re: [PATCH] lsusb: Fix bug in USB 2.0 extended caps descriptor.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping.  Greg, do you want to take this bug fix?

Sarah

On Thu, May 16, 2013 at 02:04:42PM -0700, Sarah Sharp wrote:
> The upper bits of the USB 2.0 extended capability BOS descriptor weren't
> being shifted into the right byte position.  That didn't matter much
> before now, but some USB 2.1 devices will soon have a modified BOS
> descriptor that has BESL values in those upper bits.
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> ---
>  lsusb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lsusb.c b/lsusb.c
> index d9c7908..fda772a 100644
> --- a/lsusb.c
> +++ b/lsusb.c
> @@ -3613,7 +3613,7 @@ static void dump_usb2_device_capability_desc(unsigned char *buf)
>  	unsigned int wide;
>  
>  	wide = buf[3] + (buf[4] << 8) +
> -		(buf[5] << 8) + (buf[6] << 8);
> +		(buf[5] << 16) + (buf[6] << 24);
>  	printf("  USB 2.0 Extension Device Capability:\n"
>  			"    bLength             %5u\n"
>  			"    bDescriptorType     %5u\n"
> -- 
> 1.7.9
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux