On Tuesday 28 May 2013 11:14:37 Roger Quadros wrote: > >> depends on USB_ARCH_HAS_EHCI > >> + select USB_PHY if ARCH_OMAP4 > >> + select NOP_USB_XCEIV if ARCH_OMAP4 > >> ---help--- > >> The Enhanced Host Controller Interface (EHCI) is standard for USB 2.0 > >> "high speed" (480 Mbit/sec, 60 Mbyte/sec) host controller hardware. > > > > 'select'ing USB_PHY sounds wrong too, I think you mean 'depends on'. > > > > Also note that Roger Quadros has just removed the 'select NOP_USB_XCEIV' > > there, I think you should coordinate with him. > > Selecting NOP_USB_XCEIV is wrong as it in turn depends on USB_PHY. > > I'm not for depends as it would hide USB_EHCI_HCD_OMAP in menuconfig. > I'm for explicitly selecting both, as it makes the user's life much easier. > But I'm afraid maintainers might object to that. My preferred option would be to turn the 'menuconfig PHY' into 'menu', which is what we did to solve a similar problem in drivers/mfd: It lets us 'select' specific PHY drivers without turning on the entire menu. Using 'select PHY' has the nasty side-effect of creating an incorrect dependency between the OMAP EHCI driver and all the non-OMAP phy drivers that become visible once the usb-phy directory gets enabled. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
