Re: [PATCH] staging: dwc2: remove compile warning for USB_DWC2_TRACK_MISSED_SOFS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 22, 2013 at 02:03:52PM -0700, Paul Zimmerman wrote:
> Remove the compile-time warning for this config option, and instead
> mark it as experimental in the Kconfig text
> 
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> ---
>  drivers/staging/dwc2/Kconfig    | 2 +-
>  drivers/staging/dwc2/hcd_intr.c | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
> index f0b4739..31de469 100644
> --- a/drivers/staging/dwc2/Kconfig
> +++ b/drivers/staging/dwc2/Kconfig
> @@ -36,7 +36,7 @@ config USB_DWC2_VERBOSE
>  	  If in doubt, say N.
>  
>  config USB_DWC2_TRACK_MISSED_SOFS
> -	bool "Enable Missed SOF Tracking"
> +	bool "Enable Missed SOF Tracking (EXPERIMENTAL)"

Why?  We just removed all of the "EXPERIMENTAL" markings from the
Kconfig texts for 3.9, please don't add it back in.

>  	help
>  	  Say Y here to enable logging of missed SOF events to the dmesg log.
>  	  If in doubt, say N.
> diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c
> index e84f244..e75dccb 100644
> --- a/drivers/staging/dwc2/hcd_intr.c
> +++ b/drivers/staging/dwc2/hcd_intr.c
> @@ -56,8 +56,6 @@
>  static void dwc2_track_missed_sofs(struct dwc2_hsotg *hsotg)
>  {
>  #ifdef CONFIG_USB_DWC2_TRACK_MISSED_SOFS
> -#warning Compiling code to track missed SOFs

That's fine to remove, it's annoying to me.

Care to resend this with just this chunk?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux