On 21 May 2013 22:10, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 21 May 2013, Sachin Kamat wrote: > >> On 21 May 2013 20:26, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: >> > On Tue, 21 May 2013, Sergei Shtylyov wrote: >> > >> >> Hello. >> >> >> >> On 21-05-2013 16:05, Ben Dooks wrote: >> >> >> >> >> 'omap_ehci_dt_ids' is always compiled in. Hence use of >> >> >> of_match_ptr is unnecessary. >> >> >> >> > Thought it was defined as tristate in the Kconfig. >> >> >> >> He talks about certain data structure, not the driver. >> >> And he means that it's not enclosed by #ifdef CONFIG_OF. >> >> >> >> > config USB_EHCI_HCD_OMAP >> >> > tristate "EHCI support for OMAP3 and later chips" >> >> > depends on ARCH_OMAP >> >> >> >> > this is hardly 'compiled in' here. >> >> >> >> > And even it is 'always compiled in' we could just leave this in >> >> > in case it is not always compiled in. >> >> >> >> See how of_match_ptr() is defined in <linux/of.h> depending on >> >> CONFIG_OF. >> > >> > Maybe instead of removing of_match_ptr, it would be better to enclose >> > the definition of omap_ehci_dt_ids in #ifdef CONFIG_OF/#endif. It >> > looks like that is the way it was intended to be used. >> >> Yes, it could have been done that way too. But I thought some these >> platforms might get converted to DT-only in the near future and adding >> more ifdefs would not look nice. > > Okay. You can add to all eight patches: > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Thanks Alan. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
