Re: [PATCH V2] usb: ehci-s5p: skip phy setup for Exynos5440 based platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 21 May 2013, Jingoo Han wrote:

> From: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> 
> Exynos5440 does not require any explict USB phy configuration. So skip
> the USB phy configuration for Exynos5440 based platforms.
> 
> Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> Changes since v1:
> - re-based on the latest 'linux-next' tree

This patch fails to change several occurrences of 
s5p_ehci->pdata->phy*.

Instead of taking this error-prone approach, why not define a static 
s5p_ehci_platdata structure with NULL entries?  Then for the 
Exynos5440, set s5p_ehci->pdata to point to that structure.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux