Re: [PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 21-05-2013 16:05, Ben Dooks wrote:

'omap_ehci_dt_ids' is always compiled in. Hence use of
of_match_ptr is unnecessary.

Thought it was defined as tristate in the Kconfig.

   He talks about certain data structure, not the driver.
And he means that it's not enclosed by #ifdef CONFIG_OF.

config USB_EHCI_HCD_OMAP
         tristate "EHCI support for OMAP3 and later chips"
         depends on ARCH_OMAP

this is hardly 'compiled in' here.

And even it is 'always compiled in' we could just leave this in
in case it is not always compiled in.

See how of_match_ptr() is defined in <linux/of.h> depending on CONFIG_OF.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux