RE: [PATCH] staging: dwc2: Fix dma-enabled platform devices using a default dma_mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx]
> Sent: Friday, May 17, 2013 1:53 AM
> 
> Platform devices added through OF usually do not have any dma_mask
> pointer set. If the hardware advertises DMA support, the driver will
> expect DMA buffers to be passed in, but the USB core will not do this
> due to lack of a dma mask, breaking all connectiviy.
> 
> To fix this, set a default dma_mask by pointing it at the
> coherent_dma_mask and set their value to a 32 bit mask. This still
> allows any platform code to set any more specific mask if needed, but
> makes the driver work for most dma-enabled hardware.
> 
> Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
> ---
>  drivers/staging/dwc2/platform.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> It would be great if this patch could be included in 3.10, since it is
> needed to make the dwc2 driver work on the ralink rt3052 target.
> 
> Before, the plan was to set up the dma mask in MIPS platform code, but
> because of a similar change in ehci and the uglyness of the code for
> that, the plan for that infrastructure was dropped. This patch makes the
> setting of the dma_mask happen in the same way as the patch Stephen
> Warren (set device dma_mask without reference to global data).

Acked-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux