On Fri, Apr 26, 2013 at 09:37:20AM +0000, Yuan-Hsin Chen wrote: > FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200. > FUSBH200 is an ehci-like controller with some differences. > First, register layout of FUSBH200 is incompatible with EHCI. > Furthermore, FUSBH200 is lack of siTDs which means iTDs > are used for both HS and FS ISO transfer. > > Signed-off-by: Yuan-Hsin Chen <yhchen@xxxxxxxxxxxxxxxx> This patch breaks the build on my machine, so I can't accept it: CC [M] drivers/usb/host/fusbh200-hcd.o drivers/usb/host/fusbh200-hcd.c: In function ‘dbg_hcc_params’: drivers/usb/host/fusbh200-hcd.c:149:2: error: implicit declaration of function ‘HCC_HW_PREFETCH’ [-Werror=implicit-function-declaration] drivers/usb/host/fusbh200-hcd.c:149:2: error: implicit declaration of function ‘HCC_32FRAME_PERIODIC_LIST’ [-Werror=implicit-function-declaration] drivers/usb/host/fusbh200-hcd.c:149:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 6 has type ‘char *’ [-Wformat] drivers/usb/host/fusbh200-hcd.c: At top level: drivers/usb/host/fusbh200-hcd.c:906:12: warning: ‘debug_lpm_close’ defined but not used [-Wunused-function] cc1: some warnings being treated as errors Please be more careful. Can you fix this up and resend it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
