Michael Grzeschik <mgr@xxxxxxxxxxxxxx> writes:
> From: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
>
> This patch removes the restriction of having a limited amount of only
> four active tds on one endpoint. We use the linked list implementation
> to manage all tds which get added and removed by hardware_{en,de}queue.
>
> The removal of this restriction adds the driver to run into a hardware
> errata. It's possible that the hardware will still address an transfer
> descriptor that already got cleaned up. To solve this the patch also
> postpone the cleanup of processed tds by one.
>
Some nitpicking below:
> +/*
> + * free_pending_td: remove a pending request for the endpoint
> + * @mEp: endpoint
> + */
> +void free_pending_td(struct ci13xxx_ep *mEp)
Looks like a missing "static".
> +{
> + struct td_node *pending = mEp->pending_td;
> +
> + dma_pool_free(mEp->td_pool, pending->ptr, pending->dma);
> + pending->ptr = NULL;
Why?
> + kfree(pending);
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
