Re: [PATCH] USB: fix Kconfig logic for USB_UHCI_HCD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 15 May 2013, Arnd Bergmann wrote:

> On Tuesday 14 May 2013, Alan Stern wrote:
> > The Kconfig settings for uhci-hcd are too permissive; they allow the
> > driver to be built without any bus-glue modules configured
> > (USB_UHCI_HCD enabled, PCI disabled, SPARC_LEON disabled, ARCH_VT8500
> > enabled, and USB_UHCI_PLATFORM disabled).
> > 
> > This patch fixes the problem by rearranging the dependencies.  Now the
> > platform-dependent config options don't depend on USB_UHCI_HCD;
> > instead it depends on them.  Furthermore, there is no user-selectable
> > choice as to which glue modules will be built.  If USB_UHCI_HCD is
> > enabled then all applicable bus glues will be built.
> > 
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > CC: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> 
> How do you want to handle this for OHCI and EHCI? Are you still considering
> the patches I sent for those, or do you have another solution?

Did't I already send an Acked-by for your EHCI patch?  If not, you can 
add one.

> I think we can simply remove the #error for EHCI now, and do the same
> for OHCI once we have a proper version of "USB: OHCI: prepare to make
> ohci-hcd a library module".

Yes.  I have been waiting for Manjunath to finish an acceptable version 
of that change.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux