On Wed, Apr 17, 2013 at 08:00:55PM -0700, Joe Perches wrote: > Use a more current logging style with dev_printk > where possible. > > o Convert uses of US_DEBUGP to usb_stor_dbg > o Add "struct us_data *" to usb_stor_dbg uses > o usb_stor_dbg now uses struct device */dev_vprint_emit > o Removed embedded function names > o Coalesce formats > o Remove trailing whitespace > o Remove useless OOM messages > o Remove useless function entry/exit logging > o Convert some US_DEBUGP uses to dev_info and dev_dbg > > $ size drivers/usb/storage/built-in.o* > text data bss dec hex filename > 137787 55520 68584 261891 3ff03 drivers/usb/storage/built-in.o.debug.new > 140782 55200 68904 264886 40ab6 drivers/usb/storage/built-in.o.debug.old > 102709 54936 63784 221429 360f5 drivers/usb/storage/built-in.o.no_debug.new > 101506 54568 63592 219666 35a12 drivers/usb/storage/built-in.o.no_debug.old > > Increase in no_debug size is because some previously > compiled-out US_DEBUGP are now dev_dbg and are compiled > in and a couple of US_DEBUGP messages are now dev_info. With your other patch applied, this one seems to not apply to my tree: checking file drivers/usb/storage/alauda.c checking file drivers/usb/storage/cypress_atacb.c checking file drivers/usb/storage/datafab.c checking file drivers/usb/storage/debug.c Hunk #1 FAILED at 42. Hunk #2 succeeded at 150 (offset 1 line). Hunk #3 succeeded at 172 (offset 1 line). 1 out of 3 hunks FAILED checking file drivers/usb/storage/debug.h checking file drivers/usb/storage/ene_ub6250.c checking file drivers/usb/storage/freecom.c checking file drivers/usb/storage/initializers.c checking file drivers/usb/storage/isd200.c checking file drivers/usb/storage/jumpshot.c checking file drivers/usb/storage/karma.c checking file drivers/usb/storage/option_ms.c checking file drivers/usb/storage/realtek_cr.c checking file drivers/usb/storage/scsiglue.c checking file drivers/usb/storage/sddr09.c checking file drivers/usb/storage/sddr55.c checking file drivers/usb/storage/shuttle_usbat.c checking file drivers/usb/storage/sierra_ms.c checking file drivers/usb/storage/transport.c checking file drivers/usb/storage/usb.c -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
