RE: [PATCH 04/10] staging: dwc2: disable I2CINT in dwc2_disable_host_interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx]
> Sent: Monday, April 15, 2013 7:14 AM
> 
> This interrupt is currently not enabled anywhere, but there is some
> (dummy) handling for it in the host interrupt handler. This marks it as
> a host mode interrupt, so it makes sense to disable it when disabling
> the other host mode interrupts.
> 
> Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx>
> ---
>  drivers/staging/dwc2/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
> index da9ff3a..2313f7c 100644
> --- a/drivers/staging/dwc2/core.c
> +++ b/drivers/staging/dwc2/core.c
> @@ -498,7 +498,8 @@ void dwc2_disable_host_interrupts(struct dwc2_hsotg *hsotg)
> 
>  	/* Disable host mode interrupts without disturbing common interrupts */
>  	intmsk &= ~(GINTSTS_SOF | GINTSTS_PRTINT | GINTSTS_HCHINT |
> -		    GINTSTS_PTXFEMP | GINTSTS_NPTXFEMP | GINTSTS_RXFLVL);
> +		    GINTSTS_PTXFEMP | GINTSTS_NPTXFEMP | GINTSTS_RXFLVL |
> +		    GINTSTS_I2CINT);
>  	writel(intmsk, hsotg->regs + GINTMSK);
>  }

I'd rather just get rid of the dummy code in dwc2_hcd_intr().

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux