Resending as plain text. > From: Matthijs Kooijman [mailto:matthijs@xxxxxxxx] > Sent: Monday, April 15, 2013 7:14 AM > > For host mode, this interrupt is already handled by the hcd interrupt > handler. The common interrupt handler additionally did a noop handling > (it only cleared the flag and nothing else) when in device mode. > > Since the driver currently supports only host mode, this shouldn't > result in any behaviour change in the driver. When device mode is > implemented later on, this interrupt should be properly handled by the > device interupt handler, if needed. > > This change allows to make a clean cut between common interrupts and > host interrupts, since there are no longer any interrupts handled by > both. Hi Matthijs, I'd rather keep this code as-is. The reason is, even though the driver is currently host-only, the core that it is operating may not be. In that case, when the USB cable is unplugged, the core will switch to device mode. In that case the interrupt handler for host mode will exit without clearing the interrupt. So NAK on this patch, unless you have another reason why it is required. -- Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
