Hi, On Mon, Apr 15, 2013 at 04:13:47PM +0200, Matthijs Kooijman wrote: > Before, dwc2_hcd_intr() would always return IRQ_HANDLED when the > controller was in host mode, even if no interrupt triggered that was > actually handled by by this commit message (for example for interrupts "by by this commit message" ?? > handled by the common handler). > > The check added works just like the check that is already in > dwc2_handle_common_intr(). > > Signed-off-by: Matthijs Kooijman <matthijs@xxxxxxxx> > --- > drivers/staging/dwc2/hcd_intr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c > index 0e6929c..58b7142a 100644 > --- a/drivers/staging/dwc2/hcd_intr.c > +++ b/drivers/staging/dwc2/hcd_intr.c > @@ -2083,7 +2083,8 @@ irqreturn_t dwc2_hcd_intr(struct dwc2_hsotg *hsotg) > return 0; this return 0 seems bogus... > } > > - retval = IRQ_HANDLED; > + if (gintsts & GINTMSK_HOST) > + retval = IRQ_HANDLED; you gotta be really careful with this sort of changes, it can force IRQ subsystem to disable your IRQ line. -- balbi
Attachment:
signature.asc
Description: Digital signature
