Oliver Neukum <oliver@xxxxxxxxxx> writes: > On Friday 12 April 2013 17:42:46 Ming Lei wrote: > >> Wrt. the usbnet_status_start() API, looks no good reason to call >> it in another queue context, it should be enough to call it in probe() or >> bind() if init_status() can be put before info->bind() in usbnet_probe(). > > We are talking about a generic helper. And the fix is really simple. > We just pass mem_flags and all is well. If the API can be made better > at next to no cost, we do it. I absolutely agree with this. >> Then looks the mem_flags isn't needed in both cases, and we should >> always take GFP_NOIO inside the API? > > We cannot. GFP_ATOMIC may be needed. And no, we atre not going to > unconditionally use GFP_ATOMIC :-; But I don't think we ever will need GFP_ATOMIC as long as we take a mutex lock anyway. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
