On Thursday 11 April 2013 10:28:33 Dan Williams wrote: > > Looks it isn't a good practice to duplicate code in above four functions, but > > it should be OK to merge first. > > Oliver requested this approach. I'd originally taken your suggestion to > merge them, but this proved somewhat more complicated and Oliver > rejected that approach. We don't do functions which do a different thing based on flags. Linus chewed our posteriors for that. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html